Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the
DCL_spring_bone_jointGLTF extension during asset bundle conversion, enabling spring bone physics on converted wearables and emotes.What this does
PreProcessGameObjectsphase of the custom GLTF importer, spring bone joint data is now extracted from the GLTF source and applied asSpringBoneJointComponentcomponents on the corresponding GameObjects.unity-gltfsubmodule to include:DCL_spring_bone_jointGLTF extension (stiffness, drag, gravity direction/power, hit radius, root flag)SpringBoneUtilsutility that resolves spring bone data from the GLTF node tree and maps it onto the Unity scene hierarchy by node nameHow it works
unity-gltf, which now recognizes theDCL_spring_bone_jointextension on nodes.CustomGltfImporter.PreProcessGameObjectscallsSpringBoneUtils.ApplySpringBoneJoints, passing the parsed GLTF data and the root GameObject.SpringBoneJointComponentwith the configured physics parameters.